Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the CSS rules for the overlayContainer #4777

Merged
merged 1 commit into from
May 13, 2014
Merged

Refactor the CSS rules for the overlayContainer #4777

merged 1 commit into from
May 13, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

This PR refactors the CSS for the overlayContainer, to achieve the following goals

  • Reduce unnecessary duplication of CSS rules.
  • Remove the dependency on doorHanger, since using that class seems out of place here.
  • Serve as a prerequisite to a follow-up PR I'm working on, that will change how we interact with the overlay, since the current way of doing this won't scale well if we want to add more overlays (e.g. UI for viewing and setting default preferences #3985).

/cc @timvandermeij Would you mind reviewing this?

@timvandermeij
Copy link
Contributor

If I am not mistaken, this could also help to address #3783 more easily. I will certainly review this.

@timvandermeij
Copy link
Contributor

@Snuffleupagus This looks perfectly fine to me once the ID's have been removed. Nice work (and you also thought about the RTL layout which I usually tend to forget)!

@Snuffleupagus
Copy link
Collaborator Author

The PR is updated to address the review comments. Note that I didn't think too much about the re-usability of the CSS, I only wanted to do some clean-up for an upcoming patch.

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/41583b5af1148af/output.txt

timvandermeij added a commit that referenced this pull request May 13, 2014
Refactor the CSS rules for the overlayContainer
@timvandermeij timvandermeij merged commit 36c6bc2 into mozilla:master May 13, 2014
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants