Check if the Names dictionary actually contains a Dests dictionary before attempting to get the destinations #4796
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the unit test for
getDestinations
is partially disabled, see https://github.com/mozilla/pdf.js/blob/master/test/unit/api_spec.js#L68.The problem with the file basicapi.pdf is that the
Names
dictionary is empty, so this PR makes sure that we check that before attempting to get theDests
.This PR thus makes it possible to fix a, currently meaningless, unit test.