Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the Names dictionary actually contains a Dests dictionary before attempting to get the destinations #4796

Merged
merged 2 commits into from
May 14, 2014
Merged

Check if the Names dictionary actually contains a Dests dictionary before attempting to get the destinations #4796

merged 2 commits into from
May 14, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Currently the unit test for getDestinations is partially disabled, see https://github.com/mozilla/pdf.js/blob/master/test/unit/api_spec.js#L68.

The problem with the file basicapi.pdf is that the Names dictionary is empty, so this PR makes sure that we check that before attempting to get the Dests.
This PR thus makes it possible to fix a, currently meaningless, unit test.

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/31585c37b81bf56/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/35582bbd4df3d63/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 1

Live output at: http://107.21.233.14:8877/bfcff31f26ee50d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/31585c37b81bf56/output.txt

Total script time: 0.61 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/35582bbd4df3d63/output.txt

Total script time: 0.68 mins

  • Unit Tests: Passed

yurydelendik added a commit that referenced this pull request May 14, 2014
Check if the Names dictionary actually contains a Dests dictionary before attempting to get the destinations
@yurydelendik yurydelendik merged commit df40ac9 into mozilla:master May 14, 2014
@yurydelendik
Copy link
Contributor

Really good, thanks.

@Snuffleupagus Snuffleupagus deleted the get-destinations-empty-Names branch May 14, 2014 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants