Handle nested post script arguments in the preprocessor #4799
Conversation
|
@yurydelendik Do we also need a test case? /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8c65295e2cdb253/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6197421c7b11ea5/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/8c65295e2cdb253/output.txt Total script time: 23.50 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/6197421c7b11ea5/output.txt Total script time: 26.19 mins
|
| @@ -1879,6 +1880,16 @@ var EvaluatorPreprocessor = (function EvaluatorPreprocessorClosure() { | |||
|
|
|||
| var fn = opSpec.id; | |||
|
|
|||
| if (!opSpec.variableArgs) { | |||
There was a problem hiding this comment.
Could you add args.length !== opSpec.numArgs and/or comment about why we are doing this?
The unit test at https://github.com/mozilla/pdf.js/blob/master/test/unit/evaluator_spec.js#L146 shall be changed or probably new one shall be created for |
|
Fixed the issues. |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a91fb8582d15297/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2503564dfe69c7c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a91fb8582d15297/output.txt Total script time: 23.25 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2503564dfe69c7c/output.txt Total script time: 26.27 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/04c0ce3c6c576a3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/04c0ce3c6c576a3/output.txt Total script time: 0.72 mins Published
|
Handle nested post script arguments in the preprocessor
|
Thank you for the patch |
|
I love you guys. Keep up the good work |
Fix for issue #4785