-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the interaction with overlays by adding an OverlayManager #4823
Conversation
This PR looks really good. Other than the above nits, I couldn't find anything so far that would need improvement. I'll go over this again soon just to be sure that it's all good to go. |
@timvandermeij Compared to the first version, I've made a number of changes. Sorry about that!
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7f77d650bf80e44/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7f77d650bf80e44/output.txt Total script time: 0.73 mins Published
|
Simplify the interaction with overlays by adding an OverlayManager
Nice work! |
@timvandermeij Thanks for merging! |
The current way that the overlays (
PasswordPrompt
andDocumentProperties
) are handled are less than ideal for a number of reasons. Among those are:To avoid the issues described above, and to also unify and simplify how overlays work, this PR introduces the
OverlayManager
.This PR is thus the one mentioned in #4777 (comment)
/cc @timvandermeij Would you mind reviewing this?