Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small optimizations in parser.getObj(), lexer.getObj() #4829

Merged
merged 1 commit into from
May 23, 2014

Conversation

fkaelberer
Copy link
Contributor

This reduces the number of isCmd() checks in parser.getObj() and so reduces the time spent in this function by ~20%. In street-map-like PDFs, parser.getObj() is called millions of times.

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/e1f8302664132d2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0b406e93b464fb9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/e1f8302664132d2/output.txt

Total script time: 22.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/e1f8302664132d2/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/0b406e93b464fb9/output.txt

Total script time: 26.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@fkaelberer
Copy link
Contributor Author

Bot.io (Windows):

TEST-UNEXPECTED-FAIL | test failed chrome has not responded in 120s

Firefox did pass. Try again?

@Snuffleupagus
Copy link
Collaborator

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/afb39c55dc8ab58/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/afb39c55dc8ab58/output.txt

Total script time: 22.25 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/afb39c55dc8ab58/reftest-analyzer.html#web=eq.log

@fkaelberer
Copy link
Contributor Author

Chrome timed out again, this time at a different file.

@Snuffleupagus
Copy link
Collaborator

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/202413e1e826db8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/202413e1e826db8/output.txt

Total script time: 21.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/202413e1e826db8/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

Chrome upgraded at the botio-windows from 35 -> 36.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c70d57089ce8117/output.txt

yurydelendik added a commit that referenced this pull request May 23, 2014
small optimizations in parser.getObj(), lexer.getObj()
@yurydelendik yurydelendik merged commit f000c04 into mozilla:master May 23, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

@fkaelberer fkaelberer deleted the optimize_parser_getObj branch May 23, 2014 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants