-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small optimizations in parser.getObj(), lexer.getObj() #4829
small optimizations in parser.getObj(), lexer.getObj() #4829
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e1f8302664132d2/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0b406e93b464fb9/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/e1f8302664132d2/output.txt Total script time: 22.10 mins
Image differences available at: http://107.22.172.223:8877/e1f8302664132d2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/0b406e93b464fb9/output.txt Total script time: 26.73 mins
|
Bot.io (Windows):
Firefox did pass. Try again? |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/afb39c55dc8ab58/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/afb39c55dc8ab58/output.txt Total script time: 22.25 mins
Image differences available at: http://107.22.172.223:8877/afb39c55dc8ab58/reftest-analyzer.html#web=eq.log |
Chrome timed out again, this time at a different file. |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/202413e1e826db8/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/202413e1e826db8/output.txt Total script time: 21.95 mins
Image differences available at: http://107.22.172.223:8877/202413e1e826db8/reftest-analyzer.html#web=eq.log |
Chrome upgraded at the botio-windows from 35 -> 36. |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c70d57089ce8117/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c70d57089ce8117/output.txt Total script time: 0.72 mins Published
|
small optimizations in parser.getObj(), lexer.getObj()
Thank you for the patch |
This reduces the number of isCmd() checks in parser.getObj() and so reduces the time spent in this function by ~20%. In street-map-like PDFs, parser.getObj() is called millions of times.