Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable browser cache when running test server #4870

Merged
merged 1 commit into from
Jun 10, 2014

Conversation

fkaelberer
Copy link
Contributor

This PR sets an expiration time of 1 hour for all files that are requested from the test web server, so that javascript sources are not downloaded by the browsers for each pdf file. This reduces the duration of the test significantly, from

All regression tests passed.
Runtime was 881.5 seconds

to

All regression tests passed.
Runtime was 578.2 seconds

The cache expiration time defaults to 0, so that nothing changes unless the expiration time is explicitly set.

I assumed that each browser uses a fresh profile, so that a newly started test doesn't run on old, cached code. Is that always correct?

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d53b6bdc73ed317/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8fd6180126bf237/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/8fd6180126bf237/output.txt

Total script time: 23.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/d53b6bdc73ed317/output.txt

Total script time: 24.33 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@fkaelberer
Copy link
Contributor Author

Hmm, the test bot seems rather unimpressed by this change, but still, Linux test is down to 24 mins from 26 mins in #4861, #4832, #4824, Windows test is down to 23 from 24 minutes.

@timvandermeij
Copy link
Contributor

@yurydelendik Is this good to go?

yurydelendik added a commit that referenced this pull request Jun 10, 2014
Enable browser cache when running test server
@yurydelendik yurydelendik merged commit 001238f into mozilla:master Jun 10, 2014
@yurydelendik
Copy link
Contributor

Thank you

@fkaelberer fkaelberer deleted the enableTestServerCaching branch June 27, 2014 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants