-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent adding undefined array entries to CMap.map in mapRangeToArray (issue 4875) #4876
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/3298168e45ed131/output.txt |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 2 Live output at: http://107.21.233.14:8877/5f05651cde55898/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/18679dba4e251b2/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/3298168e45ed131/output.txt Total script time: 0.72 mins Published
|
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/18679dba4e251b2/output.txt Total script time: 7.11 mins
Image differences available at: http://107.22.172.223:8877/18679dba4e251b2/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6e99f0f14fc5bd8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5f05651cde55898/output.txt Total script time: 26.08 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/6e99f0f14fc5bd8/output.txt Total script time: 23.92 mins
|
Looks good. Thanks |
Prevent adding undefined array entries to CMap.map in mapRangeToArray (issue 4875)
Tentative patch to fix #4875.
I'm not sure if this is the correct/optimal way to fix the issue, which is the reason that I didn't bother including a test file yet. Also I didn't want to waste time running the botio tests until I knew if this patch is any good (note however that it does pass all tests locally).