Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding undefined array entries to CMap.map in mapRangeToArray (issue 4875) #4876

Merged
merged 1 commit into from
Jun 2, 2014
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Tentative patch to fix #4875.

I'm not sure if this is the correct/optimal way to fix the issue, which is the reason that I didn't bother including a test file yet. Also I didn't want to waste time running the botio tests until I knew if this patch is any good (note however that it does pass all tests locally).

@yurydelendik
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/3298168e45ed131/output.txt

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 2

Live output at: http://107.21.233.14:8877/5f05651cde55898/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/18679dba4e251b2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/18679dba4e251b2/output.txt

Total script time: 7.11 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/18679dba4e251b2/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6e99f0f14fc5bd8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5f05651cde55898/output.txt

Total script time: 26.08 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/6e99f0f14fc5bd8/output.txt

Total script time: 23.92 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Looks good. Thanks

yurydelendik added a commit that referenced this pull request Jun 2, 2014
Prevent adding undefined array entries to CMap.map in mapRangeToArray (issue 4875)
@yurydelendik yurydelendik merged commit 3acf570 into mozilla:master Jun 2, 2014
@Snuffleupagus Snuffleupagus deleted the issue-4875 branch June 2, 2014 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of CMap/ToUnicode is very (too?) strict
3 participants