Protects PDFJS.disableXXX == true from change #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses regression mentioned in #4898 (comment) |
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ee09f6499a48e83/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ee09f6499a48e83/output.txt Total script time: 0.88 mins Published
|
|
Trivial |
yurydelendik
added a commit
that referenced
this pull request
Jun 12, 2014
Protects PDFJS.disableXXX == true from change
| @@ -223,21 +223,33 @@ var PDFView = { | |||
|
|
|||
| var initializedPromise = Promise.all([ | |||
| Preferences.get('enableWebGL').then(function resolved(value) { | |||
| if (PDFJS.disableWebGL === true) { | |||
There was a problem hiding this comment.
Given that the default value is true, see https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L122-L123, shouldn't this have been === false instead?
With this PR merged, WebGL is now disabled even though I've set the pref to true in about:config.
There was a problem hiding this comment.
hmmm, you are right. let's remove that check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... when preferences read