Halve the size of the PageView cache. #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I wanted to do that long ago too. |
yurydelendik
added a commit
that referenced
this pull request
Jun 13, 2014
Halve the size of the PageView cache.
|
Thanks for all the fast responses you've given me in the past 24 hours! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PageView cache currently has a max size of 20. That seems overly generous. This patch reduces it to 10.
On my MacBook with a retina screen, the canvas for each page is typically about 22 MiB, so this reduces peak memory usage by 10 x 22 = 220 MiB. On my Linux desktop it's about 5.5 MiB per page, so it saves 10 x 5.5 = 55 MiB.