-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster JPEG transform #4950
Faster JPEG transform #4950
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0fd7abbb894ae9c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/0fd7abbb894ae9c/output.txt Total script time: 0.73 mins Published
|
I can confirm that this makes the document load a second faster. Nice work! /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/58413fec8ad7ec2/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/3c6c06d3c3f3344/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/58413fec8ad7ec2/output.txt Total script time: 20.84 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/3c6c06d3c3f3344/output.txt Total script time: 24.32 mins
Image differences available at: http://107.21.233.14:8877/3c6c06d3c3f3344/reftest-analyzer.html#web=eq.log |
Since this PR only touches jpg.js, I'm pretty sure that the Linux differences are caused by some other PR not getting a proper makeref... |
/botio-linux test (because makeref has been done after a Firefox update on the bots) |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/dfb303e48dd3bc7/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/dfb303e48dd3bc7/output.txt Total script time: 24.12 mins
|
reviewed the code and verified the performance results. can be merged after @fkaelberer fixes the nits above. |
Done. I fixed the nits and renamed |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b4a2d4c922785de/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/63162ac39d6b584/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/63162ac39d6b584/output.txt Total script time: 2.77 mins
Image differences available at: http://107.22.172.223:8877/63162ac39d6b584/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/82a4425003eb83d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b4a2d4c922785de/output.txt Total script time: 23.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/82a4425003eb83d/output.txt Total script time: 21.71 mins
|
Thank you for the patch |
This PR doubles the speed of the inverse JPEG transform and so saves one second when decoding #3809.