Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster JPEG transform #4950

Merged
merged 1 commit into from
Jun 17, 2014
Merged

Conversation

fkaelberer
Copy link
Contributor

This PR doubles the speed of the inverse JPEG transform and so saves one second when decoding #3809.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0fd7abbb894ae9c/output.txt

@timvandermeij
Copy link
Contributor

I can confirm that this makes the document load a second faster. Nice work!

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/58413fec8ad7ec2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3c6c06d3c3f3344/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/58413fec8ad7ec2/output.txt

Total script time: 20.84 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/3c6c06d3c3f3344/output.txt

Total script time: 24.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/3c6c06d3c3f3344/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

Since this PR only touches jpg.js, I'm pretty sure that the Linux differences are caused by some other PR not getting a proper makeref...

@timvandermeij
Copy link
Contributor

/botio-linux test

(because makeref has been done after a Firefox update on the bots)

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/dfb303e48dd3bc7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/dfb303e48dd3bc7/output.txt

Total script time: 24.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@CodingFabian
Copy link
Contributor

reviewed the code and verified the performance results. can be merged after @fkaelberer fixes the nits above.

@fkaelberer
Copy link
Contributor Author

Done. I fixed the nits and renamed i to row and col as they were named before. Also added one minor tweak at line 511.

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b4a2d4c922785de/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/63162ac39d6b584/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/63162ac39d6b584/output.txt

Total script time: 2.77 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/63162ac39d6b584/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/82a4425003eb83d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b4a2d4c922785de/output.txt

Total script time: 23.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/82a4425003eb83d/output.txt

Total script time: 21.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Jun 17, 2014
@yurydelendik yurydelendik merged commit bad24bf into mozilla:master Jun 17, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

@fkaelberer fkaelberer deleted the fasterJPEGtransform branch June 26, 2014 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants