Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes AnnotationUtils in the extension build #4970

Merged
merged 2 commits into from
Jun 18, 2014

Conversation

yurydelendik
Copy link
Contributor

No description provided.

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ad056b00195554f/output.txt

@Snuffleupagus
Copy link
Collaborator

I should have caught this while doing the review in #4965, but I only tested locally, sorry about that!

One question though: Is this line still necessary https://github.com/mozilla/pdf.js/blob/master/src/core/annotation.js#L321?

@yurydelendik
Copy link
Contributor Author

Nope, removed.

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ca8f32fc4f0ed64/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/716f60ec4c5a0b6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/716f60ec4c5a0b6/output.txt

Total script time: 21.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/ca8f32fc4f0ed64/output.txt

Total script time: 23.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Snuffleupagus added a commit that referenced this pull request Jun 18, 2014
Fixes AnnotationUtils in the extension build
@Snuffleupagus Snuffleupagus merged commit 7a83291 into mozilla:master Jun 18, 2014
@Snuffleupagus
Copy link
Collaborator

Thank you!

@yurydelendik yurydelendik deleted the AnnotationUtils branch June 19, 2014 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants