Converting PDFFindBar and PDFFindController to classes #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.resumePageIdx = pageIdx; | ||
| break; | ||
| updateUIState: function PDFFindController_updateUIState(state, previous) { | ||
| if (this.findBar === null) { |
There was a problem hiding this comment.
You could/should move this down and place it after if (this.integratedFind) { ... }, since it really doesn't matter if this.findBar is defined when the integrated find is used.
There was a problem hiding this comment.
Done in the new commit.
timvandermeij
changed the title
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/932b9477f0fa855/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/932b9477f0fa855/output.txt Total script time: 0.72 mins Published
|
|
Looks good to me. Thank you. |
yurydelendik
added a commit
that referenced
this pull request
Aug 5, 2014
Converting PDFFindBar and PDFFindController to classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
viewer.js,page_view.jsandtext_layer_builder.jsaccordingly;Tip: https://github.com/mozilla/pdf.js/pull/5007/files?w=1 makes review much more pleasant.