Use Array.join() to build strings in the PostScript parser

[Snuffleupagus]

Similar to a number of previous patches, let's avoid creating a bunch of unnecessary strings in the PostScript parser.

[Snuffleupagus]

/botio unittest

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/909a6f1f805caa6/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/af76e2a6f7ef6e1/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/909a6f1f805caa6/output.txt

Total script time: 0.70 mins

• Unit Tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/af76e2a6f7ef6e1/output.txt

Total script time: 0.96 mins

• Unit Tests: Passed

[CodingFabian]

looks good to me

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/68b4b9214659068/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/68b4b9214659068/output.txt

Total script time: 0.98 mins

Published

• Viewer: http://107.21.233.14:8877/68b4b9214659068/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/68b4b9214659068/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/68b4b9214659068/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/68b4b9214659068/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/23426832f995ddd/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2e833f09e855c9f/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/2e833f09e855c9f/output.txt

Total script time: 2.74 mins

• Font tests: FAILED
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/2e833f09e855c9f/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/23426832f995ddd/output.txt

Total script time: 36.74 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[fkaelberer]

Maybe you can also replace successive calls of String.fromCharCode with a single call of Utils.bytesToString, which is much faster in my experience. Considering nnethercote's comment that strings use 16-32 bytes, it should also be more memory-friendly to collect the char codes in the array instead of short strings.

[Snuffleupagus]

Closing in favour of PR #5063.