-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a couple of reduced test-cases for PR 4259 #5105
Conversation
PR 4259 fixed a large number of font bugs, but none of those where added as test-cases. This was, in my opinion, unfortunate since it increases the risk of regressions in the future when other font bugs are fixed. This PR simply adds a few more test-cases, to improve our test coverage somewhat.
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/87735abc93cb7e0/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/87735abc93cb7e0/output.txt Total script time: 23.26 mins
|
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/07034d08f3cd03b/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/07034d08f3cd03b/output.txt Total script time: 19.65 mins
Image differences available at: http://107.22.172.223:8877/07034d08f3cd03b/reftest-analyzer.html#web=eq.log |
The failures are because of a Firefox update (see #3891). This PR is good to go, so making new references here will also fix the update differences. /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e435a8d6d6966a0/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e113c177a91ea7f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e435a8d6d6966a0/output.txt Total script time: 20.15 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e113c177a91ea7f/output.txt Total script time: 23.21 mins
|
Add a couple of reduced test-cases for PR 4259
Nice, thanks! |
PR #4259 fixed a large number of font bugs, but none of those where added as test-cases. This was, in my opinion, unfortunate since it increases the risk of regressions in the future when other font bugs are fixed.
This PR simply adds a few more test-cases, to improve our test coverage somewhat.