Properly set this.eof in CCITTFaxStream

[timvandermeij]

Fixes #5133.
Fixes #4379 (two PDFs).
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=776608 (five PDFs).
Fixes all PDFs at http://www.institute-christ-king.org/latin-mass-resources/sacred-music (over 200 PDFs!).

Easier review: https://github.com/mozilla/pdf.js/pull/5136/files?w=1

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/336a6aa1f4cd598/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4d20a6a65bc2701/output.txt

[CodingFabian]

i can confirm that this fixes the issue. the #4379 example you also chose for testing looks to be simple enough to check in rather than using the link feature.

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/4d20a6a65bc2701/output.txt

Total script time: 19.69 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/4d20a6a65bc2701/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Linux)

---

Failed

Full output at http://107.21.233.14:8877/336a6aa1f4cd598/output.txt

Total script time: 22.88 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/336a6aa1f4cd598/reftest-analyzer.html#web=eq.log

[CodingFabian]

looks like

• firefox-issue1597-page1
• firefox-annotation-as-page1
• firefox-annotation-as-page2

also had the same horizontal line issue that is fixed now.

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/75f92af42a46fc1/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/75f92af42a46fc1/output.txt

Total script time: 0.76 mins

Published

• Viewer: http://107.21.233.14:8877/75f92af42a46fc1/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/75f92af42a46fc1/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/75f92af42a46fc1/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/75f92af42a46fc1/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c6def9618297bca/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/20aeec71e07c5c2/output.txt

[yurydelendik]

thank you for the patch

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/20aeec71e07c5c2/output.txt

Total script time: 19.87 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/c6def9618297bca/output.txt

Total script time: 22.70 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed