Avoid repeated creation of a simple RegExp object.

[nnethercote]

This helps avoid creation of tens or hundreds of thousands of objects for the doc in #4487, which reduces cumulative memory allocations by about 2%. Not a huge improvement, but not bad for something so simple.

[CodingFabian]

nice. I assume its not worth extracting the regex from
https://github.com/mozilla/pdf.js/blob/master/src/core/network.js#L193
because its only called tens to hundreds of times?

[CodingFabian]

also:
https://github.com/mozilla/pdf.js/blob/master/src/shared/util.js#L271
and
https://github.com/mozilla/pdf.js/blob/master/src/shared/util.js#L303
have a similar looking regex, which is however not hot.

https://github.com/mozilla/pdf.js/blob/master/src/core/obj.js#L1023
looks to be hotter. Worth extracting as well?

[nnethercote]

Worth extracting as well?

Depends how hot they are. I haven't seen them come up in any of my memory profiles. Anything less than 10,000 executions probably isn't worth bothering with.

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1c8b714961186df/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/1c8b714961186df/output.txt

Total script time: 0.75 mins

Published

• Viewer: http://107.21.233.14:8877/1c8b714961186df/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/1c8b714961186df/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/1c8b714961186df/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/1c8b714961186df/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

Looks good. Thank you!