Attempt to display the File size quicker in the Document Properties dialog #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialog Currently the File size field in the Document Properties dialog isn't set until `PDFView.pdfDocument.getDownloadInfo()` is resolved. If the Document Properties dialog is opened while a PDF file is loading with range requests, this leads to the less desirable situation where all fields *except* File size are available. In cases where `PDFView.open()` is called with the `args` parameter defined, and `args` contains the property `length`, we actually know the File size when the PDF file begins to load. (This is usually the case when ranged loading is used in the Firefox addon/built-in version.) Hence we can use `args.length` to set the File size immediately when `PDFView.open()` is called, resulting in a better user experience.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/955ef12d733dedb/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/955ef12d733dedb/output.txt Total script time: 0.73 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Aug 11, 2014
…-fileSize Attempt to display the File size quicker in the Document Properties dialog
|
Confirmed with the generated extension. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the File size field in the Document Properties dialog isn't set until
PDFView.pdfDocument.getDownloadInfo()is resolved. If the Document Properties dialog is opened while a PDF file is loading with range requests, this leads to the less desirable situation where all fields except File size are available.In cases where
PDFView.open()is called with theargsparameter defined, andargscontains the propertylength, we actually know the File size when the PDF file begins to load. (This is usually the case when ranged loading is used in the Firefox addon/built-in version.)Hence we can use
args.lengthto set the File size immediately whenPDFView.open()is called, resulting in a better user experience.