Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add even more unit tests for the API #5174

Merged
merged 1 commit into from
Aug 12, 2014
Merged

Add even more unit tests for the API #5174

merged 1 commit into from
Aug 12, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

This patch replaces most of the remaining TODOs in test/unit/api_spec.js with actual tests.

@Snuffleupagus
Add even more unit tests for the API
fc5ad8a 
This patch replaces most of the remaining TODOs in test/unit/api_spec.js with actual tests.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0d791ac0a32cdc6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/96059095400ee35/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/0d791ac0a32cdc6/output.txt

Total script time: 0.61 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/96059095400ee35/output.txt

Total script time: 0.71 mins

  • Unit Tests: FAILED

@yurydelendik
Copy link
Contributor

/botio-windows unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_unittest from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b18825633d63eb3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/b18825633d63eb3/output.txt

Total script time: 0.74 mins

  • Unit Tests: Passed

yurydelendik added a commit that referenced this pull request Aug 12, 2014
@yurydelendik
Merge pull request #5174 from Snuffleupagus/even-more-api-unittests
41a5bce 
Add even more unit tests for the API
@yurydelendik yurydelendik merged commit 41a5bce into mozilla:master Aug 12, 2014
@yurydelendik
Copy link
Contributor

Looks good. Thanks!

@Snuffleupagus Snuffleupagus deleted the even-more-api-unittests branch August 12, 2014 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @pdfjsbot @yurydelendik @timvandermeij