-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cff glyph width in the hmtx table #5184
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f5a2afab310d49f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/35af1d6be960e96/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/35af1d6be960e96/output.txt Total script time: 19.82 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f5a2afab310d49f/output.txt Total script time: 22.44 mins
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/db47a655eae9bc7/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/db47a655eae9bc7/output.txt Total script time: 0.75 mins Published
|
if (charstrings) { | ||
var charstring = charstrings[i - 1]; | ||
width = 'width' in charstring ? charstring.width : 0; | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since cffWidths
can be null
, to prevent any future bugs, shouldn't this line read:
} else if (cffWidths) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... or change the next line to:
width = Math.ceil((cffWidths && cffWidths[i]) || 0);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/fc60d1ea624254d/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/acc52564e97b8b2/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/fc60d1ea624254d/output.txt Total script time: 19.66 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/acc52564e97b8b2/output.txt Total script time: 22.47 mins
|
Use cff glyph width in the hmtx table
As far as I can tell this looks good; thank you! |
Fixes #4986
Provides widths for the glyphs extracted from the CFF charstrings.