-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set transformOrigin for text layer in css. #5209
Set transformOrigin for text layer in css. #5209
Conversation
@CodingFabian Could you remove the unrelated CSS changes so we only keep the |
you mean the removal of the unused rules i can make an extra pr for that. |
You can put those in a separate commit for this PR. As long as it's separated from the intended change (which is to remove CustomStyle and inline those rules), it's fine to keep it in this PR. |
transformOrigin is set to 0% 0% in all cases. This adds extra memory impact into the dom tree. It also involves the CustomStyles workaround to determine the correct css rule for the browser. By setting all vendor and standard variants in css, the rule is applied without the dom memory overhead and without the minor computation overhead to set the value.
d8f78a9
to
1da38ec
Compare
like it this way better? i had no luck convincing atom not to fixup the trailing whitespaces :) |
@CodingFabian That's fine, thanks. |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/492577d170eeb58/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/492577d170eeb58/output.txt Total script time: 0.76 mins Published
|
Set transformOrigin for text layer in css.
Thank you! |
transformOrigin is set to 0% 0% in all cases. This adds extra memory
impact into the dom tree. It also involves the CustomStyles workaround
to determine the correct css rule for the browser.
By setting all vendor and standard variants in css, the rule is applied
without the dom memory overhead and without the minor computation
overhead to set the value.