Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set transformOrigin for text layer in css. #5209

Merged

Conversation

CodingFabian
Copy link
Contributor

transformOrigin is set to 0% 0% in all cases. This adds extra memory
impact into the dom tree. It also involves the CustomStyles workaround
to determine the correct css rule for the browser.
By setting all vendor and standard variants in css, the rule is applied
without the dom memory overhead and without the minor computation
overhead to set the value.

@timvandermeij
Copy link
Contributor

@CodingFabian Could you remove the unrelated CSS changes so we only keep the CustomStyle removal and the transform-origin rules?

@CodingFabian
Copy link
Contributor Author

you mean the removal of the unused rules
color: #000;
font-family: sans-serif;

i can make an extra pr for that.
Also my editor corrected trailing whitespace. shall i remove that as well?

@timvandermeij
Copy link
Contributor

You can put those in a separate commit for this PR. As long as it's separated from the intended change (which is to remove CustomStyle and inline those rules), it's fine to keep it in this PR.

transformOrigin is set to 0% 0% in all cases. This adds extra memory
impact into the dom tree. It also involves the CustomStyles workaround
to determine the correct css rule for the browser.
By setting all vendor and standard variants in css, the rule is applied
without the dom memory overhead and without the minor computation
overhead to set the value.
@CodingFabian CodingFabian force-pushed the text-layer-transform-origin branch from d8f78a9 to 1da38ec Compare August 19, 2014 20:47
@CodingFabian
Copy link
Contributor Author

like it this way better? i had no luck convincing atom not to fixup the trailing whitespaces :)

@timvandermeij
Copy link
Contributor

@CodingFabian That's fine, thanks.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/492577d170eeb58/output.txt

timvandermeij added a commit that referenced this pull request Aug 19, 2014
Set transformOrigin for text layer in css.
@timvandermeij timvandermeij merged commit b4fb1e2 into mozilla:master Aug 19, 2014
@timvandermeij
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants