Chrome extension: Isolate pageAction logic #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove pageAction logic from extension router, and put it in a separate file. The pageAction URL parsing logic has been simplified, and all pageAction-related files have been moved to a separate directory.
|
Yes, that would also do the trick. Thank you. |
Snuffleupagus
added a commit
that referenced
this pull request
Aug 26, 2014
Chrome extension: Isolate pageAction logic
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pageAction logic from extension router, and put it in a separate file. The pageAction URL parsing logic has been simplified, and all pageAction-related files have been moved to a separate directory.
This change is motivated by the desire of @csillag to re-use PDF.js extension code without the pageAction feature.