Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for TrueType fonts with exotic cmap tables (bug 1057544) #5233

Merged
merged 1 commit into from
Sep 15, 2014
Merged

Workaround for TrueType fonts with exotic cmap tables (bug 1057544) #5233

merged 1 commit into from
Sep 15, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1057544.

The TrueType font used in the file has a (0, 1) cmap table, which we currently don't support. Adding support for more kinds of cmap tables is tracked in #5231, which I'll happily leave for @brendandahl when he gets back :-)

In the meantime, I'm submitting this patch to workaround the bug. Prior to #4259, we used to default to a (3, 1) cmap table when no standard one was found, which is why I hope this patch will be OK as a temporary fix.

Note: I'm expecting some movement, for the better, on issue4800.pdf since it has a (0, 1) cmap.

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f46d2bc17313006/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ddb574961b1fd39/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/7d1b5da1c9a38b0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/ddb574961b1fd39/output.txt

Total script time: 2.89 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/ddb574961b1fd39/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/7d1b5da1c9a38b0/output.txt

Total script time: 23.24 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/7d1b5da1c9a38b0/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/302c5c1ba8d71d7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7e6c4158da5b1bf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/7e6c4158da5b1bf/output.txt

Total script time: 20.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/7e6c4158da5b1bf/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/302c5c1ba8d71d7/output.txt

Total script time: 22.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/302c5c1ba8d71d7/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus added this to the 2014 Q3 milestone Aug 31, 2014
@brendandahl
Copy link
Contributor

WFM, thanks!

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/eb19fc11b9c324a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/228127b88f76bee/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/eb19fc11b9c324a/output.txt

Total script time: 21.75 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/228127b88f76bee/output.txt

Total script time: 22.53 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

brendandahl added a commit that referenced this pull request Sep 15, 2014
Workaround for TrueType fonts with exotic cmap tables (bug 1057544)
@brendandahl brendandahl merged commit 403b7df into mozilla:master Sep 15, 2014
@Snuffleupagus Snuffleupagus deleted the bug-1057544 branch September 15, 2014 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants