-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for TrueType fonts with exotic cmap tables (bug 1057544) #5233
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f46d2bc17313006/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f46d2bc17313006/output.txt Total script time: 0.98 mins Published
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ddb574961b1fd39/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7d1b5da1c9a38b0/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/ddb574961b1fd39/output.txt Total script time: 2.89 mins
Image differences available at: http://107.22.172.223:8877/ddb574961b1fd39/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/7d1b5da1c9a38b0/output.txt Total script time: 23.24 mins
Image differences available at: http://107.21.233.14:8877/7d1b5da1c9a38b0/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/302c5c1ba8d71d7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7e6c4158da5b1bf/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/7e6c4158da5b1bf/output.txt Total script time: 20.34 mins
Image differences available at: http://107.22.172.223:8877/7e6c4158da5b1bf/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/302c5c1ba8d71d7/output.txt Total script time: 22.36 mins
Image differences available at: http://107.21.233.14:8877/302c5c1ba8d71d7/reftest-analyzer.html#web=eq.log |
WFM, thanks! |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/eb19fc11b9c324a/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/228127b88f76bee/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/eb19fc11b9c324a/output.txt Total script time: 21.75 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/228127b88f76bee/output.txt Total script time: 22.53 mins
|
Workaround for TrueType fonts with exotic cmap tables (bug 1057544)
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1057544.
The TrueType font used in the file has a (0, 1) cmap table, which we currently don't support. Adding support for more kinds of cmap tables is tracked in #5231, which I'll happily leave for @brendandahl when he gets back :-)
In the meantime, I'm submitting this patch to workaround the bug. Prior to #4259, we used to default to a (3, 1) cmap table when no standard one was found, which is why I hope this patch will be OK as a temporary fix.
Note: I'm expecting some movement, for the better, on issue4800.pdf since it has a (0, 1) cmap.