Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Symbol fonts without font file but with Encoding dictionary (issue 5238) #5250

Merged
merged 1 commit into from
Sep 26, 2014
Merged

Fix Symbol fonts without font file but with Encoding dictionary (issue 5238) #5250

merged 1 commit into from
Sep 26, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #5238.

The (missing) bullets on the first page are using the ZapfDingbats encoding, which we have never supported (and there are already other issues/bugs filed about that). Edit: Will be fixed by #5251.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e1b05585d056360/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fd0df8e2aac9d06/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/fd0df8e2aac9d06/output.txt

Total script time: 22.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/e1b05585d056360/output.txt

Total script time: 22.77 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

In PR #4362, I fixed missing symbols in https://partners.adobe.com/public/developer/en/font/5015.Type1_Supp.pdf. I just discovered that PR #4259 broke those, but fortunately it will be fixed (again) by this patch.

@Snuffleupagus
Copy link
Collaborator Author

The PR was updated to fix a merge conflict in the .gitignore file.

@timvandermeij
Copy link
Contributor

@yurydelendik Is more work needed for this PR or can we land it?

@yurydelendik
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fda2c4938964a20/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1d07e43c87dc2a3/output.txt

yurydelendik added a commit that referenced this pull request Sep 26, 2014
Fix Symbol fonts without font file but with Encoding dictionary (issue 5238)
@yurydelendik yurydelendik merged commit 744c8e8 into mozilla:master Sep 26, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/fda2c4938964a20/output.txt

Total script time: 21.31 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1d07e43c87dc2a3/output.txt

Total script time: 22.24 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character µ not displayed
4 participants