Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for ZapfDingbats #5251

Merged
merged 2 commits into from
Sep 3, 2014
Merged

Add basic support for ZapfDingbats #5251

merged 2 commits into from
Sep 3, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

This patch adds support for the ZapfDingbats encoding, and should thus fix issues/bugs with titles like: "check marks rendered as a number (4)".

Compared to the rendering in Adobe Reader, many of the glyphs doesn't look as nice. However, it should still be a marked improvement compared to the current situation where we don't even attempt to draw the correct glyphs.

/cc @yurydelendik

Fixes #1577.
Fixes #2738.
Fixes #3032.
Fixes bug 846359.
Fixes bug 846675.

Edit: I added support for additional (depreciated) Mac OS specific dingbats glyphs, to make sure that we handle older documents correct. Note that we already, as for the "standard" dingbats glyphs, include width data for these.
Also, I found a document that can be used for testing: http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/Tests/zapf-dingbats.pdf (from http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/).
Should we include this as a "linked" test?

@jscodefix
Copy link

I ran tests, using the Snuffleupagus:dingbats branch, against my PDF documents, and confirmed that checkboxes are now properly displayed.

@yurydelendik yurydelendik added this to the 2014 Q3 milestone Sep 2, 2014
@yurydelendik yurydelendik self-assigned this Sep 2, 2014
@yurydelendik
Copy link
Contributor

Really good. I'll check that soon.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b9a8c7899aafa7f/output.txt

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/972c49c471903e1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e0f92ec56e92eb8/output.txt

@yurydelendik
Copy link
Contributor

I found a document that can be used for testing: http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/Tests/zapf-dingbats.pdf (from http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/).
Should we include this as a "linked" test?

Yes (as a linked test)

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/972c49c471903e1/output.txt

Total script time: 2.81 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/972c49c471903e1/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/e0f92ec56e92eb8/output.txt

Total script time: 22.57 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/e0f92ec56e92eb8/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d144e2adc0874bd/output.txt

@yurydelendik
Copy link
Contributor

Text from http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/Tests/zapf-dingbats.fo:

<?xml version="1.0" encoding="ISO-8859-1"?><!-- 
    (c) RenderX, 2000 
    This file makes part of the RenderX XSL FO Test Suite. Permission is 
    granted to copy and modify this file as a whole or in part, provided 
    that any work derived from it bear a reference to the original
    document.
  -->

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/d144e2adc0874bd/output.txt

Total script time: 22.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/d144e2adc0874bd/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8ca21e51c140cd3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9cad8d64ba18bcb/output.txt

yurydelendik added a commit that referenced this pull request Sep 3, 2014
Add basic support for ZapfDingbats
@yurydelendik yurydelendik merged commit 40ebf71 into mozilla:master Sep 3, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/9cad8d64ba18bcb/output.txt

Total script time: 0.98 mins

  • Lint: Passed
  • Make references: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/8ca21e51c140cd3/output.txt

Total script time: 22.44 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@yurydelendik
Copy link
Contributor

/botio-windows makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8e8450cc0ee30c7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/8e8450cc0ee30c7/output.txt

Total script time: 20.86 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment