-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for ZapfDingbats #5251
Conversation
I ran tests, using the Snuffleupagus:dingbats branch, against my PDF documents, and confirmed that checkboxes are now properly displayed. |
Really good. I'll check that soon. |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b9a8c7899aafa7f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b9a8c7899aafa7f/output.txt Total script time: 0.78 mins Published
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/972c49c471903e1/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e0f92ec56e92eb8/output.txt |
Yes (as a linked test) |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/972c49c471903e1/output.txt Total script time: 2.81 mins
Image differences available at: http://107.22.172.223:8877/972c49c471903e1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/e0f92ec56e92eb8/output.txt Total script time: 22.57 mins
Image differences available at: http://107.21.233.14:8877/e0f92ec56e92eb8/reftest-analyzer.html#web=eq.log |
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d144e2adc0874bd/output.txt |
Text from http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/Tests/zapf-dingbats.fo:
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/d144e2adc0874bd/output.txt Total script time: 22.47 mins
Image differences available at: http://107.21.233.14:8877/d144e2adc0874bd/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8ca21e51c140cd3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9cad8d64ba18bcb/output.txt |
Add basic support for ZapfDingbats
Thank you for the patch |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/9cad8d64ba18bcb/output.txt Total script time: 0.98 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8ca21e51c140cd3/output.txt Total script time: 22.44 mins
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8e8450cc0ee30c7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/8e8450cc0ee30c7/output.txt Total script time: 20.86 mins
|
This patch adds support for the
ZapfDingbats
encoding, and should thus fix issues/bugs with titles like: "check marks rendered as a number (4)".Compared to the rendering in Adobe Reader, many of the glyphs doesn't look as nice. However, it should still be a marked improvement compared to the current situation where we don't even attempt to draw the correct glyphs.
/cc @yurydelendik
Fixes #1577.
Fixes #2738.
Fixes #3032.
Fixes bug 846359.
Fixes bug 846675.
Edit: I added support for additional (depreciated) Mac OS specific dingbats glyphs, to make sure that we handle older documents correct. Note that we already, as for the "standard" dingbats glyphs, include width data for these.
Also, I found a document that can be used for testing: http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/Tests/zapf-dingbats.pdf (from http://www.w3.org/Style/XSL/TestSuite/contrib/XEP/).
Should we include this as a "linked" test?