Handtool: Remove focus from previous node on click #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"This commit fixes the issue that a focused element cannot lose focus when the draggable element is clicked." Rob--W/grab-to-pan.js@11c368f97cebe19 Steps to reproduce/verify: 1. Enable the hand tool (e.g. by using the H shortcut) 2. Click on the Page number input. 3. Click or drag the PDF canvas. 4. Observe that the page number input is still focused. Consequently, the hand tool cannot be disabled using the H shortcut.
Rob--W
force-pushed
the
handtool-unfocus
branch
from
f993b30 to
204d540
Compare
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/19ab3f087f7a211/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/19ab3f087f7a211/output.txt Total script time: 0.91 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Sep 3, 2014
Handtool: Remove focus from previous node on click
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"This commit fixes the issue that a focused element cannot lose
focus when the draggable element is clicked."
Rob--W/grab-to-pan.js@dae91a92ee47bf2
Steps to reproduce/verify:
After applying this patch, the input field will lose focus at step 3, and at step 4 the hand tool can successfully be toggled using the H shortcut.