TextLayer selection coloring improvement for overlap. #5282
Conversation
|
screenshots from the document of #1045 after: |
|
Unfortunately these changes make the "find" highlight very difficult to spot, so this patch still needs some work. |
CodingFabian
force-pushed
the
nicer-overlapping-text-selection
branch
from
26e8c01 to
9bbb8e7
Compare
|
oops yeah, i forgot to include that factor in the two other alpha values for highlights. fixed now. |
|
The "find" highlights are still slightly lighter, but I don't know how much that matters. |
|
no they are percentage. Its now 60% of 30% which is less than 20% which it was before. I assume that doesnt matter much. Maybe, we could even get rid of the 20% and make text selection and search highlight overall 30% (so remove the opacity from the highlight css) |
So it shall be 66 or 67% ? |
|
;-) If the exact color needs to be matched its not doable at all. We can do 0.66 for sure, but maybe its an option to go for 30% for all highlights (selection and find)? |
As a consequence of merging mozilla#5221 it is more likely to have multiple overlapping selection divs inside the text layer. Because each individual element gets the selection style applied, the 30%opacity stacks, making a 60% bar visible where the overlap happens. As proposed by @rocallahan, this can be fixed by making the selection style solid and setting opacity for the overall layer. I assume also that this should make the work for the renderer easier, but was unable to bench it.
CodingFabian
force-pushed
the
nicer-overlapping-text-selection
branch
from
9bbb8e7 to
931b444
Compare
|
i played a bit and settled on making the text selection 20% as well. i think thats even nicer than before. The change now keeps alpha values for find highlighting and makes text selection lighter, but more importantly overlapping seconds do not create darker areas anymore. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d60ddfff810bad3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d60ddfff810bad3/output.txt Total script time: 0.77 mins Published
|
|
I agree with @CodingFabian that this looks a lot better than before (with the overlapping areas). |
|
@yurydelendik what do you think? is it ok to align the selection opacity? and do you like how it looks now or does it need improvement? |
…ection TextLayer selection coloring improvement for overlap.
|
CodingFabian: thank you for the nice improvement! |
As a consequence of merging #5221 it is more likely to have multiple
overlapping selection divs inside the text layer. Because each individual
element gets the selection style applied, the 30%opacity stacks, making a
60% bar visible where the overlap happens.
As proposed by @rocallahan, this can be fixed by making the selection
style solid and setting opacity for the overall layer.
I assume also that this should make the work for the renderer easier, but
was unable to bench it.