-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch decodeParams if it's a |Ref| in JBIG2Decode streams #5284
Conversation
@@ -1044,6 +1044,9 @@ var Jbig2Stream = (function Jbig2StreamClosure() { | |||
} | |||
decodeParams = decodeParams[0]; | |||
} | |||
if (decodeParams) { | |||
decodeParams = this.dict.xref.fetchIfRef(decodeParams); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move it before isArray check? Arrays can be referred by ref too
Could you also add var xref = this.dict.xref;
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving it seems reasonable, but we also need it in the isArray
case otherwise we don't actually fix the bug.
The xref
variable has been added.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/47bfac9d071f981/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7a0c1f4745d19d7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/47bfac9d071f981/output.txt Total script time: 19.86 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7a0c1f4745d19d7/output.txt Total script time: 22.61 mins
|
Fetch decodeParams if it's a |Ref| in JBIG2Decode streams
Thank you for the patch |
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1064894.