Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch decodeParams if it's a |Ref| in JBIG2Decode streams #5284

Merged
merged 1 commit into from
Sep 10, 2014
Merged

Fetch decodeParams if it's a |Ref| in JBIG2Decode streams #5284

merged 1 commit into from
Sep 10, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus changed the title Fetch decodeParams it is a |ref| in JBIG2Decode streams Fetch decodeParams it is a |Ref| in JBIG2Decode streams Sep 9, 2014
@@ -1044,6 +1044,9 @@ var Jbig2Stream = (function Jbig2StreamClosure() {
}
decodeParams = decodeParams[0];
}
if (decodeParams) {
decodeParams = this.dict.xref.fetchIfRef(decodeParams);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move it before isArray check? Arrays can be referred by ref too

Could you also add var xref = this.dict.xref;?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving it seems reasonable, but we also need it in the isArray case otherwise we don't actually fix the bug.
The xref variable has been added.

@Snuffleupagus Snuffleupagus changed the title Fetch decodeParams it is a |Ref| in JBIG2Decode streams Fetch decodeParams if it's a |Ref| in JBIG2Decode streams Sep 9, 2014
@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/47bfac9d071f981/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/7a0c1f4745d19d7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/47bfac9d071f981/output.txt

Total script time: 19.86 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/7a0c1f4745d19d7/output.txt

Total script time: 22.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Sep 10, 2014
Fetch decodeParams if it's a |Ref| in JBIG2Decode streams
@yurydelendik yurydelendik merged commit c84a569 into mozilla:master Sep 10, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants