Miscellaneous e10s fixes #5305
Miscellaneous e10s fixes #5305
Conversation
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
I think changing the license of the file should be explained in the commit. changing license under the covers of "misc fixes" is dubious. I have read the bugzilla where the license change was discussed and it should be referenced.
There was a problem hiding this comment.
The relevant commit message already said: Update the license header in extensions/firefox/content/pdfjschildbootstrap.js, so I'm not really sure how this can be considered dubious.
"Miscellaneous e10s fixes" is the title of the PR, not the indiviual commits. Anyway, I've amended the commit with a link to the relevant Bugzilla comment.
The PDF.js project uses the Apache v2 license, but unfortunately the file didn't land with the correct license header. Hence I figured I would address that in this PR.
Since I needed to submit a few other e10s fixes, in this case, it seemed reasonable to submit a few different commits in the same PR to speed up the merging process.
There was a problem hiding this comment.
Here you go -- reference to the license-to-license-change:
…/firefox/content/PdfStreamConverter.jsm
| @@ -176,7 +178,9 @@ let PdfjsChromeUtils = { | |||
| }, | |||
|
|
|||
| _isPrefAllowed: function (aPrefName) { | |||
There was a problem hiding this comment.
The name _isPrefAllowed seems somewhat misleading to me, since it suggests that the method should return a boolean value.
@yurydelendik, @brendandahl Would it make sense to rename this to e.g. _throwIfPrefIsNotAllowed instead?
There was a problem hiding this comment.
Can you rename it to _ensurePreferenceAllowed ?
|
Looks good after the change above... or as is |
…irefox/content/PdfjsChromeUtils.jsm
|
Thank you |
No description provided.