Lowerize the params to allow case sensitive

[manolopm]

Think now it's covered

[yurydelendik]

Make sure all usages of the returned map are lower-cased as well, e.g. at https://github.com/mozilla/pdf.js/blob/master/web/viewer.js#L1772

[manolopm]

The preferences should be in lower case to be consistent? or it's better to keep the preferences in camel case?

Manuel Padrón Martínez

—
Reply to this email directly or view it on GitHub .

[yurydelendik]

The preferences should be in lower case to be consistent? or it's better to keep the preferences in camel case?

After your change the preferences will stop working -- anywhere your code affects that you shall change the case if the preference.

I'm not interested in changing the documentation yet. So they can be in camel case there.

[yurydelendik]

https://bugzilla.mozilla.org/show_bug.cgi?id=1068582

[Rob--W]

If we take http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_open_parameters.pdf as the standard, then most values must be case-insensitive as well.

I suggest to replace hashParams[...] with a function that gets the parameters (e.g. getHashParam), and perhaps another method for some common uses, e.g.getHashParamAsBoolean. Then it will also be easier to supportdisableWorker=1instead ofdisableWorker=true`. Adobe seems to use digits (0 and 1) for boolean parameters, so this change would improve the consistency of our URL format.

[yurydelendik]

Thank you for the patch