Firefox addon: Use isContentWindowPrivate instead of isWindowPrivate if available #5364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
changed the title
Rob--W
force-pushed
the
firefox-pbu_isWindowPrivate
branch
from
a78e9f9 to
8c411e4
Compare
|
Looks good to me. @yurydelendik Could you also review this? |
|
Can you invert logic to check on non-existence of the method and call older version, and strip that for mozilla central? |
As of Firefox 35, isContentWindowPrivate should be used for DOM windows instead of isWindowPrivate. See https://bugzilla.mozilla.org/show_bug.cgi?id=1069059 and http://hg.mozilla.org/mozilla-central/diff/324798b60ba3/toolkit/modules/PrivateBrowsingUtils.jsm Without this fix, you will get the following error message when Firefox+PDF.js is started: > WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts). pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14 ChromeActions.prototype.isInPrivateBrowsing@resource://pdf.js/PdfStreamConverter.jsm:237:12 xhr_onreadystatechange@resource://pdf.js/PdfStreamConverter.jsm:545:30 NetworkManager_requestRange@resource://pdf.js/network.js:95:7 NetworkManager_requestRange@resource://pdf.js/network.js:81:14 RangedChromeActions_requestDataRange@resource://pdf.js/PdfStreamConverter.jsm:596:1 RequestListener.prototype.receive@resource://pdf.js/PdfStreamConverter.jsm:705:5 PdfStreamConverter.prototype.onStartRequest/proxy.onStopRequest/<@resource://pdf.js/PdfStreamConverter.jsm:909:11 FirefoxComClosure/<.request@resource://pdf.js/web/viewer.js:529:14 PdfDataRangeTransport_requestDataRange@resource://pdf.js/web/viewer.js:2977:9 transportDataRange@resource://pdf.js/build/pdf.js:2122:13 messageHandlerComObjOnMessage@resource://pdf.js/build/pdf.js:1219:9
Rob--W
force-pushed
the
firefox-pbu_isWindowPrivate
branch
from
8c411e4 to
4fe92f6
Compare
|
@yurydelendik Done. |
|
awesome! thank you /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0bc0bf80ec83f73/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0bc0bf80ec83f73/output.txt Total script time: 0.83 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Oct 1, 2014
Firefox addon: Use isContentWindowPrivate instead of isWindowPrivate if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Firefox 35,
PrivateBrowsingUtilsisContentWindowPrivateshould be used for DOM windows instead ofPrivateBrowsingUtils.isWindowPrivate. See https://bugzilla.mozilla.org/show_bug.cgi?id=1069059 and http://hg.mozilla.org/mozilla-central/diff/324798b60ba3/toolkit/modules/PrivateBrowsingUtils.jsmWithout this fix, you will get the following error message when Firefox+PDF.js is started: