Don't map glyphs to unicode non breaking space. #5379

brendandahl · 2014-10-02T17:59:27Z

Looks like 160 is also a bad spot to use as a char code. Fixes #5138.

brendandahl · 2014-10-02T17:59:56Z

/botio test

pdfjsbot · 2014-10-02T17:59:59Z

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/022ceaa89005057/output.txt

pdfjsbot · 2014-10-02T17:59:59Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/483cf7175f866c5/output.txt

pdfjsbot · 2014-10-02T18:02:52Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/483cf7175f866c5/output.txt

Total script time: 2.88 mins

Font tests: FAILED
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/483cf7175f866c5/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-10-02T18:03:43Z

/botio-windows test

pdfjsbot · 2014-10-02T18:03:43Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6b6829711c796bf/output.txt

brendandahl · 2014-10-02T18:05:32Z

Also fixes #5239

pdfjsbot · 2014-10-02T18:23:02Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/022ceaa89005057/output.txt

Total script time: 23.05 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/022ceaa89005057/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-10-02T18:23:16Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/6b6829711c796bf/output.txt

Total script time: 19.54 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/6b6829711c796bf/reftest-analyzer.html#web=eq.log

brendandahl · 2014-10-03T19:11:34Z

/botio test

pdfjsbot · 2014-10-03T19:11:34Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0ca33301755b323/output.txt

pdfjsbot · 2014-10-03T19:11:34Z

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/aced8a6493392dc/output.txt

pdfjsbot · 2014-10-03T19:14:29Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/0ca33301755b323/output.txt

Total script time: 2.91 mins

Font tests: FAILED
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/0ca33301755b323/reftest-analyzer.html#web=eq.log

brendandahl · 2014-10-03T19:17:06Z

/botio-windows test

pdfjsbot · 2014-10-03T19:17:06Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/09c39b242fdcb0a/output.txt

pdfjsbot · 2014-10-03T19:34:38Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/aced8a6493392dc/output.txt

Total script time: 23.05 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/aced8a6493392dc/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-10-03T19:36:56Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/09c39b242fdcb0a/output.txt

Total script time: 19.83 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

brendandahl · 2014-10-30T22:50:01Z

/botio test

pdfjsbot · 2014-10-30T22:50:01Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/228d68b3622f92c/output.txt

pdfjsbot · 2014-10-30T22:50:01Z

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ebab5b4fda3c422/output.txt

pdfjsbot · 2014-10-30T23:07:57Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/228d68b3622f92c/output.txt

Total script time: 17.93 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/228d68b3622f92c/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-10-30T23:13:33Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/ebab5b4fda3c422/output.txt

Total script time: 23.53 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/ebab5b4fda3c422/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2014-11-25T22:29:55Z

/botio-windows test

pdfjsbot · 2014-11-25T22:29:56Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/73d27457b836b63/output.txt

pdfjsbot · 2014-11-25T22:50:38Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/73d27457b836b63/output.txt

Total script time: 20.70 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

Snuffleupagus · 2014-12-08T22:21:51Z

This PR will also fix the font issue in https://bugzilla.mozilla.org/show_bug.cgi?id=1107257.
(The printing issue described is probably a duplicate of other bugs, since it sounds like it may be related to the cleanup timeout.)

@yurydelendik Is this PR good to land?

yurydelendik · 2014-12-18T19:13:31Z

/botio test

pdfjsbot · 2014-12-18T19:13:31Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5408ccd30181d9d/output.txt

pdfjsbot · 2014-12-18T19:13:31Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2c79f8afeaf637d/output.txt

pdfjsbot · 2014-12-18T19:30:41Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/5408ccd30181d9d/output.txt

Total script time: 17.17 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2014-12-18T19:36:12Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/2c79f8afeaf637d/output.txt

Total script time: 22.68 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/2c79f8afeaf637d/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-12-18T19:37:52Z

/botio makeref

pdfjsbot · 2014-12-18T19:37:52Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c0a21f946d20317/output.txt

pdfjsbot · 2014-12-18T19:37:52Z

From: Bot.io (Linux)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/a168da4e9c63062/output.txt

yurydelendik · 2014-12-18T19:38:00Z

thank you for the patch

Don't map glyphs to unicode non breaking space.

pdfjsbot · 2014-12-18T19:55:05Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/c0a21f946d20317/output.txt

Total script time: 17.21 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2014-12-18T20:00:26Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/a168da4e9c63062/output.txt

Total script time: 22.56 mins

Lint: Passed
Make references: Passed
Check references: Passed

Don't map glyphs to unicode non breaking space.

Don't map glyphs to unicode non breaking space.

2fc5e6a

timvandermeij added the font-conversion label Oct 2, 2014

Map missing glyphs in encoding to notdef glyph.

8a536ac

yurydelendik self-assigned this Oct 23, 2014

takahiroyoshi mentioned this pull request Nov 8, 2014

Strange characters show instead of space characters in IE11 #4836

Closed

yurydelendik added a commit that referenced this pull request Dec 18, 2014

Merge pull request #5379 from brendandahl/nbsp

31ae5f2

Don't map glyphs to unicode non breaking space.

yurydelendik merged commit 31ae5f2 into mozilla:master Dec 18, 2014

timvandermeij mentioned this pull request Dec 18, 2014

Character स is not displayed #5239

Closed

speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015

Merge pull request mozilla#5379 from brendandahl/nbsp

87c5f93

Don't map glyphs to unicode non breaking space.

Don't map glyphs to unicode non breaking space. #5379

Don't map glyphs to unicode non breaking space. #5379

Conversation

brendandahl commented Oct 2, 2014

brendandahl commented Oct 2, 2014

pdfjsbot commented Oct 2, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Oct 2, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 2, 2014

From: Bot.io (Windows)

Failed

yurydelendik commented Oct 2, 2014

pdfjsbot commented Oct 2, 2014

From: Bot.io (Windows)

Received

brendandahl commented Oct 2, 2014

pdfjsbot commented Oct 2, 2014

From: Bot.io (Linux)

Failed

pdfjsbot commented Oct 2, 2014

From: Bot.io (Windows)

Failed

brendandahl commented Oct 3, 2014

pdfjsbot commented Oct 3, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 3, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Oct 3, 2014

From: Bot.io (Windows)

Failed

brendandahl commented Oct 3, 2014

pdfjsbot commented Oct 3, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 3, 2014

From: Bot.io (Linux)

Failed

pdfjsbot commented Oct 3, 2014

From: Bot.io (Windows)

Success

brendandahl commented Oct 30, 2014

pdfjsbot commented Oct 30, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 30, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Oct 30, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented Oct 30, 2014

From: Bot.io (Linux)

Failed

Snuffleupagus commented Nov 25, 2014

pdfjsbot commented Nov 25, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 25, 2014

From: Bot.io (Windows)

Success

Snuffleupagus commented Dec 8, 2014

yurydelendik commented Dec 18, 2014

pdfjsbot commented Dec 18, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Dec 18, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Dec 18, 2014

From: Bot.io (Windows)

Success

pdfjsbot commented Dec 18, 2014

From: Bot.io (Linux)

Failed

yurydelendik commented Dec 18, 2014