-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reduced test case for PR 5286 #5390
Add a reduced test case for PR 5286 #5390
Conversation
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 2 Live output at: http://107.22.172.223:8877/6e09525f02e365d/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/6e09525f02e365d/output.txt Total script time: 2.76 mins
Image differences available at: http://107.22.172.223:8877/6e09525f02e365d/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/00febdc139c40cc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/00febdc139c40cc/output.txt Total script time: 18.45 mins
|
really good, thanks! /botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/59238c86414c003/output.txt |
…-test-case Add a reduced test case for PR 5286
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/59238c86414c003/output.txt Total script time: 17.92 mins
|
When submitting PR #5286, I didn't include a test case. The reason was that I wanted to avoid adding a linked test, since most of the issues referred to files at various hosting services (hence with uncertain future availability). Manually creating a test case seemed "hard" so I just skipped it, which is obviously bad since it greatly increases the risk of future regressions.
However I recently noticed that for one of the PDF files it was possible to easily, using only a text editor and PDFtk, remove any potentially sensitive content and still have a meaningful test case, hence this patch.