Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reduced test case for PR 5286 #5390

Merged
merged 1 commit into from
Oct 22, 2014
Merged

Add a reduced test case for PR 5286 #5390

merged 1 commit into from
Oct 22, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

When submitting PR #5286, I didn't include a test case. The reason was that I wanted to avoid adding a linked test, since most of the issues referred to files at various hosting services (hence with uncertain future availability). Manually creating a test case seemed "hard" so I just skipped it, which is obviously bad since it greatly increases the risk of future regressions.

However I recently noticed that for one of the PDF files it was possible to easily, using only a text editor and PDFtk, remove any potentially sensitive content and still have a meaningful test case, hence this patch.

@yurydelendik
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 2

Live output at: http://107.22.172.223:8877/6e09525f02e365d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/6e09525f02e365d/output.txt

Total script time: 2.76 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/6e09525f02e365d/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/00febdc139c40cc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/00febdc139c40cc/output.txt

Total script time: 18.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

really good, thanks!

/botio-windows makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/59238c86414c003/output.txt

yurydelendik added a commit that referenced this pull request Oct 22, 2014
…-test-case

Add a reduced test case for PR 5286
@yurydelendik yurydelendik merged commit 9e7966a into mozilla:master Oct 22, 2014
@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/59238c86414c003/output.txt

Total script time: 17.92 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the inline-jpeg-image-loading-test-case branch October 22, 2014 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants