-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors PdfDataLister buffering. #5402
Conversation
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/35202f87521b028/output.txt |
// We own the chunk data, so we can store it as is. | ||
this.buffer = chunk; | ||
} else { | ||
var newBuffer = new Uint8Array(this.buffer.length + chunkLength); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chunk.length
instead?
Also, what about caching this.buffer.length
to avoid recomputing it below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chunkLength fixed
this.buffer replaced by buffer
d3ac685
to
0ba1022
Compare
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/35202f87521b028/output.txt Total script time: 18.63 mins
Image differences available at: http://107.21.233.14:8877/35202f87521b028/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/12f2c37bc06eef4/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/12f2c37bc06eef4/output.txt Total script time: 0.79 mins Published
|
0ba1022
to
63444aa
Compare
Refactors PdfDataLister buffering.
Fixes #5400