Black text not visible #5291 #5409
Conversation
|
@thejdeep Could you squash your commits into one commit? See https://github.com/mozilla/pdf.js/wiki/Squashing-Commits on how to do this easily. |
thejdeep
force-pushed
the
master
branch
2 times, most recently
from
6acc9c0 to
d7c02a4
Compare
|
@yurydelendik any updates on including the test PDF ? |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1885863c83a7241/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/1885863c83a7241/output.txt Total script time: 17.86 mins
Image differences available at: http://107.22.172.223:8877/1885863c83a7241/reftest-analyzer.html#web=eq.log |
|
With this PR the text (in #5291) is visible, but compared to the rendering in Adobe Reader it unfortunately doesn't really fix the issue: |
|
Also, tests are failing. Something looks wrong about |
|
|
||
| var browserFontSize = size < MIN_FONT_SIZE ? MIN_FONT_SIZE : | ||
| size > MAX_FONT_SIZE ? MAX_FONT_SIZE : size; | ||
| this.current.fontSizeScale = size/browserFontSize; |
There was a problem hiding this comment.
nit: add spaces around '/'
|
@thejdeep Could you squash the commits again? |
|
@timvandermeij Squashing merge commits diverges my branch from origin/master . Help |
|
Following either of first two sections at https://github.com/mozilla/pdf.js/wiki/Squashing-Commits shall fix any diverging. (https://github.com/mozilla/pdf.js/pull/5409.diff shall contain the current branch's diff, you can also reset your "master" |
|
the main problem is that you sent a pull request from master. never do that. always create a feature branch that avoids many issues. |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/200a658ae707aca/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/200a658ae707aca/output.txt Total script time: 18.35 mins
|
Black text not visible #5291
|
Thank you for the patch |
Waiting for test