Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow localization of the placement of percent signs in the zoom box #5416

Merged
merged 1 commit into from
Nov 11, 2014
Merged

Allow localization of the placement of percent signs in the zoom box #5416

merged 1 commit into from
Nov 11, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #3837.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6d9dc284de38566/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/6d9dc284de38566/output.txt

Total script time: 0.77 mins

Published

@yurydelendik
Copy link
Contributor

github does not let comment on html diff:

<option title="" value="1.5" data-l10n-id="page_scale_percent" data-l10n-args='{ "scale": "150" }' >150%</option>

has extra space before > and can we keep scale value without the quotes?

@Snuffleupagus
Copy link
Collaborator Author

has extra space before > and can we keep scale value without the quotes?

Fixed, thank you!

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/92b34d50e466006/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/92b34d50e466006/output.txt

Total script time: 0.77 mins

Published

@yurydelendik yurydelendik self-assigned this Oct 23, 2014
yurydelendik added a commit that referenced this pull request Nov 11, 2014
@yurydelendik
Merge pull request #5416 from Snuffleupagus/percent-sign-l10n
3b9a78d 
Allow localization of the placement of percent signs in the zoom box
@yurydelendik yurydelendik merged commit 3b9a78d into mozilla:master Nov 11, 2014
@yurydelendik
Copy link
Contributor

Thank you

@Snuffleupagus Snuffleupagus deleted the percent-sign-l10n branch November 11, 2014 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yurydelendik yurydelendik

Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zoom options (50%, 100%, etc.) aren’t translatable
3 participants
@Snuffleupagus @pdfjsbot @yurydelendik