Added try/catch #5427 #5448
Added try/catch #5427 #5448
Conversation
| pendingRequest.mozChunked = true; | ||
| } else { | ||
| xhr.responseType = 'arraybuffer'; | ||
| // Some legacy broswers might throw an exception |
There was a problem hiding this comment.
Spelling nit: browsers. Also please end sentences with a period.
|
Also, please update the commit message to something a bit more descriptive and please squash the commits once you have addressed the review comments. |
thejdeep
force-pushed
the
androidfix
branch
2 times, most recently
from
c0ab658 to
f4bb1af
Compare
| if (xhr.responseType === 'moz-chunked-arraybuffer') { | ||
| pendingRequest.onProgressiveData = args.onProgressiveData; | ||
| pendingRequest.mozChunked = true; | ||
| } else { | ||
| xhr.responseType = 'arraybuffer'; | ||
| xhr.responseType = 'arraybuffer'; |
There was a problem hiding this comment.
One last nit: the indentation is incorrect here, please revert this change.
thejdeep
force-pushed
the
androidfix
branch
2 times, most recently
from
0cc63a7 to
4653e65
Compare
Fix for pdf on android not visible Fix for pdf on android not visible
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9d8f9b1e61ef2f7/output.txt |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7dd536126776148/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7dd536126776148/output.txt Total script time: 0.76 mins Published
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9d8f9b1e61ef2f7/output.txt Total script time: 18.09 mins
|
|
@yurydelendik Is this good to go? |
|
Yes. Thank you for the patch. |
No description provided.