Add basic support for non-embedded Wingdings fonts #5463

Snuffleupagus · 2014-11-01T13:07:12Z

This is a tentative patch that adds very basic support for non-embedded Wingdings fonts (a Windows version of Dingbats), by falling back to the ZapfDingbats encoding. Obviously this approach will not work perfectly, but in my opinion it seems to work reasonably well in pratice.

Instead of this very simple patch, another option would be to try and include more complete glyph data for Wingdings, e.g. a Unicode map and glyph widths, similar to what was done for ZapfDingbats.
However there is, in my opinion, one important difference between Wingdings and ZapfDingbats: ZapfDingbats is part of the 14 standard fonts, which in previous versions of the PDF specification was assumed to be available in PDF readers. To improve compatibility with older files, it thus makes sense for us to include data for ZapfDingbats.
However Wingdings has never been a standard font in PDF files, hence PDF files using it should thus contain all the necessary font data.

Given the above, I thus believe that it should be OK to fall back to ZapfDingbats for now. If non-embedded Wingdings fonts turns out to be a lot more common, then we can revisit this later.

Fixes #4301 completely.
Fixes #4837 almost completely. With this patch the bullets are displayed correctly, but the arrows are not of the correct type.
Fixes artofwar.pdf, pages 14 and 15.

Snuffleupagus · 2014-11-01T13:07:44Z

/botio-linux preview

pdfjsbot · 2014-11-01T13:07:45Z

From: Bot.io (Linux)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5f1c69575a56166/output.txt

pdfjsbot · 2014-11-01T13:08:31Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/5f1c69575a56166/output.txt

Total script time: 0.77 mins

Published

Viewer: http://107.21.233.14:8877/5f1c69575a56166/web/viewer.html
B2G Viewer: http://107.21.233.14:8877/5f1c69575a56166/extensions/b2g/content/web/viewer.html
Extension: http://107.21.233.14:8877/5f1c69575a56166/extensions/firefox/pdf.js.xpi
Extension (AMO): http://107.21.233.14:8877/5f1c69575a56166/extensions/firefox/pdf.js.amo.xpi

Rob--W · 2014-11-02T09:33:57Z

src/core/evaluator.js

@@ -1310,7 +1310,8 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
          if (!properties.file) {
            if (/Symbol/i.test(properties.name)) {
              encoding = Encodings.SymbolSetEncoding;
-            } else if (/Dingbats/i.test(properties.name)) {
+            } else if (/Dingbats/i.test(properties.name) ||
+                       /Wingdings/i.test(properties.name)) {


Collapse the two regular expressions into one: /Dingbats|Wingdings/i (also in fonts.js)

Done, thanks!

Snuffleupagus · 2014-11-02T10:52:08Z

/botio test

pdfjsbot · 2014-11-02T10:52:09Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d789d02b3b6706e/output.txt

pdfjsbot · 2014-11-02T10:52:09Z

From: Bot.io (Linux)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3cabcda031a3967/output.txt

pdfjsbot · 2014-11-02T10:55:08Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/d789d02b3b6706e/output.txt

Total script time: 2.98 mins

Font tests: FAILED
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/d789d02b3b6706e/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-11-02T11:15:42Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/3cabcda031a3967/output.txt

Total script time: 23.55 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/3cabcda031a3967/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-12-05T16:02:21Z

really good, however I think the best place for that is nonStdFontMap. will it be possible to redo the logic based on that?

Snuffleupagus · 2014-12-05T17:06:35Z

however I think the best place for that is nonStdFontMap. will it be possible to redo the logic based on that?

That seems to works just as well. Is the updated patch more in line with what you had in mind?

yurydelendik · 2014-12-05T17:14:50Z

Yeah, something like that. I was actually curious if we still need changes in the symbolsFonts and the warning.

Snuffleupagus · 2014-12-05T17:20:02Z

I figured the warning was a good idea since, as I noted above, this PR isn't a complete solution for Wingdings support (but good enough for now in my opinion).

Edit: Sorry, I missed your comment about symbolsFonts. It (obviously) works just as well without it, so I've removed that part too.

timvandermeij · 2014-12-08T22:59:39Z

The patch makes sense to me. I think the warning is fine in case the substitution is not perfect and people report an issue about it. It will give us a clue about what the issue is and how often it occurs, and it should not disturb the regular user if it's only visible in the console.

Good to go?

Rob--W · 2014-12-08T23:10:01Z

src/core/fonts.js

@@ -2500,6 +2501,10 @@ var Font = (function FontClosure() {
          this.toFontChar[charCode] = fontChar;
        }
      } else if (/Dingbats/i.test(fontName)) {
+        if (name.search(/Wingdings/i) !== -1) {


Use /Windings/i.test(name) instead of name.search() !== -1.

This is a tentative patch that adds *very* basic support for non-embedded Wingdings fonts (a Windows version of Dingbats), by falling back to the ZapfDingbats encoding. Obviously this approach will not work perfectly, but in my opinion it seems to work reasonably well in pratice. Instead of this very simple patch, another option would be to try and include more complete glyph data for Wingdings, e.g. a Unicode map and glyph widths, similar to what was done for ZapfDingbats. However there is, in my opinion, one important difference between Wingdings and ZapfDingbats: ZapfDingbats is part of the 14 standard fonts, which in previous versions of the PDF specification was assumed to be available in PDF readers. To improve compatibility with older files, it thus makes sense for us to include data for ZapfDingbats. However Wingdings has never been a standard font in PDF files, hence PDF files using it *should* thus contain all the necessary font data. Given the above, I thus believe that it should be OK to fall back to ZapfDingbats for now. If non-embedded Wingdings fonts turns out to be *a lot* more common, then we can revisit this later. Fixes 4301 completely. Fixes 4837 almost completely. With this patch the bullets are displayed correctly, but the arrows are not of the correct type. Fixes `artofwar.pdf`, pages 14 and 15.

timvandermeij · 2014-12-15T20:01:57Z

/botio test

pdfjsbot · 2014-12-15T20:01:59Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c94595481d2c7e2/output.txt

pdfjsbot · 2014-12-15T20:01:59Z

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f1865b9460f8a38/output.txt

pdfjsbot · 2014-12-15T20:19:06Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/c94595481d2c7e2/output.txt

Total script time: 17.11 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/c94595481d2c7e2/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-12-15T20:24:22Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/f1865b9460f8a38/output.txt

Total script time: 22.38 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/f1865b9460f8a38/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-12-18T17:29:33Z

/botio makeref

Thank you

pdfjsbot · 2014-12-18T17:29:34Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/649b044d23edc1f/output.txt

pdfjsbot · 2014-12-18T17:29:34Z

From: Bot.io (Linux)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/63c4f85855903de/output.txt

Add basic support for non-embedded Wingdings fonts

pdfjsbot · 2014-12-18T17:46:57Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/649b044d23edc1f/output.txt

Total script time: 17.38 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2014-12-18T17:52:13Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/63c4f85855903de/output.txt

Total script time: 22.65 mins

Lint: Passed
Make references: Passed
Check references: Passed

Add basic support for non-embedded Wingdings fonts

Snuffleupagus added the font-conversion label Nov 1, 2014

Rob--W reviewed Nov 2, 2014
View reviewed changes

yurydelendik self-assigned this Dec 5, 2014

Rob--W reviewed Dec 8, 2014
View reviewed changes

yurydelendik added a commit that referenced this pull request Dec 18, 2014

Merge pull request #5463 from Snuffleupagus/wingdings

0c3a8ba

Add basic support for non-embedded Wingdings fonts

yurydelendik merged commit 0c3a8ba into mozilla:master Dec 18, 2014

Snuffleupagus deleted the wingdings branch December 18, 2014 18:33

timvandermeij mentioned this pull request Dec 18, 2014

Document shows ÿ instead of bullets #4837

Closed

speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015

Merge pull request mozilla#5463 from Snuffleupagus/wingdings

9ea9c3d

Add basic support for non-embedded Wingdings fonts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic support for non-embedded Wingdings fonts #5463

Add basic support for non-embedded Wingdings fonts #5463

Snuffleupagus commented Nov 1, 2014

Snuffleupagus commented Nov 1, 2014

pdfjsbot commented Nov 1, 2014

pdfjsbot commented Nov 1, 2014

Rob--W Nov 2, 2014

Snuffleupagus Nov 2, 2014

Snuffleupagus commented Nov 2, 2014

pdfjsbot commented Nov 2, 2014

pdfjsbot commented Nov 2, 2014

pdfjsbot commented Nov 2, 2014

pdfjsbot commented Nov 2, 2014

yurydelendik commented Dec 5, 2014

Snuffleupagus commented Dec 5, 2014

yurydelendik commented Dec 5, 2014

Snuffleupagus commented Dec 5, 2014

timvandermeij commented Dec 8, 2014

Rob--W Dec 8, 2014

timvandermeij commented Dec 15, 2014

pdfjsbot commented Dec 15, 2014

pdfjsbot commented Dec 15, 2014

pdfjsbot commented Dec 15, 2014

pdfjsbot commented Dec 15, 2014

yurydelendik commented Dec 18, 2014

pdfjsbot commented Dec 18, 2014

pdfjsbot commented Dec 18, 2014

pdfjsbot commented Dec 18, 2014

pdfjsbot commented Dec 18, 2014

Add basic support for non-embedded Wingdings fonts #5463

Add basic support for non-embedded Wingdings fonts #5463

Conversation

Snuffleupagus commented Nov 1, 2014

Snuffleupagus commented Nov 1, 2014

pdfjsbot commented Nov 1, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 1, 2014

From: Bot.io (Linux)

Success

Published

Rob--W Nov 2, 2014

Choose a reason for hiding this comment

Snuffleupagus Nov 2, 2014

Choose a reason for hiding this comment

Snuffleupagus commented Nov 2, 2014

pdfjsbot commented Nov 2, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 2, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 2, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented Nov 2, 2014

From: Bot.io (Linux)

Failed

yurydelendik commented Dec 5, 2014

Snuffleupagus commented Dec 5, 2014

yurydelendik commented Dec 5, 2014

Snuffleupagus commented Dec 5, 2014

timvandermeij commented Dec 8, 2014

Rob--W Dec 8, 2014

Choose a reason for hiding this comment

timvandermeij commented Dec 15, 2014

pdfjsbot commented Dec 15, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Dec 15, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Dec 15, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented Dec 15, 2014

From: Bot.io (Linux)

Failed

yurydelendik commented Dec 18, 2014

pdfjsbot commented Dec 18, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Dec 18, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Dec 18, 2014

From: Bot.io (Windows)

Success

pdfjsbot commented Dec 18, 2014

From: Bot.io (Linux)

Success