Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent text selection in Presentation Mode (bug 1018882) #5478

Merged
merged 2 commits into from
Nov 11, 2014
Merged

Prevent text selection in Presentation Mode (bug 1018882) #5478

merged 2 commits into from
Nov 11, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1018882.
(I got tired of receiving lots of bug mail about something that is, in my opinion, a very minor issue. Hence this PR ;-)

Note that no unprefixed version of user-select exists, see: https://developer.mozilla.org/en-US/docs/Web/CSS/user-select.

There is also an edge case of all text already being selected when Presentation Mode is entered. This isn't something that the bug covers, so I wasn't sure if we wanted to address that as well, hence a separate commit (to make it easier to revert the code changes if this feature isn't necessary).

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Nov 7, 2014

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4d08fa14b6fdb9a/output.txt

yurydelendik added a commit that referenced this pull request Nov 11, 2014
Prevent text selection in Presentation Mode (bug 1018882)
@yurydelendik yurydelendik merged commit bb91aa5 into mozilla:master Nov 11, 2014
@yurydelendik
Copy link
Contributor

Awesome, thanks!

@Snuffleupagus Snuffleupagus deleted the bug-1018882 branch November 11, 2014 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants