Prevent a "TypeError: pdfViewer is null" when the viewer loads (PR 5413 followup) #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…13 followup) Currently if you manage to e.g. open the console (with <kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>K</kbd>) before the viewer is initialized, the following will be printed in the console: `TypeError: pdfViewer is null`. This doesn't cause any actual errors, but nevertheless it seems like something we should avoid. Followup to PR 5413.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b74acf6a48f04b7/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b74acf6a48f04b7/output.txt Total script time: 0.76 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Nov 18, 2014
…followup Prevent a "TypeError: pdfViewer is null" when the viewer loads (PR 5413 followup)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you manage to e.g. open the console (with Ctrl+Shift+K) before the viewer is initialized, the following will be printed in the console:
TypeError: pdfViewer is null.This doesn't cause any actual errors, but nevertheless it seems like something we should avoid.
Followup to PR #5413.