Bug 639134 - update check for document colors

[gijsk]

This checks for both prefs on the understanding that we need to work on older versions of Firefox. If that isn't the case, the first part of the if isn't necessary. This should only land if bug 639134 is resolved - I'd make the patch part of that bug, but AIUI pdfjs's canonical repo is on github, so...

[yurydelendik]

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ffe9923db37a0d1/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/ffe9923db37a0d1/output.txt

Total script time: 0.91 mins

Published

• Viewer: http://107.22.172.223:8877/ffe9923db37a0d1/web/viewer.html
• B2G Viewer: http://107.22.172.223:8877/ffe9923db37a0d1/extensions/b2g/content/web/viewer.html
• Extension: http://107.22.172.223:8877/ffe9923db37a0d1/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/ffe9923db37a0d1/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

https://bugzilla.mozilla.org/show_bug.cgi?id=639134 is landed in FF37 and patch looks good -- trying to figure out when we regressed the warning bar

[Snuffleupagus]

We might want to hold off with this PR, since there's apparently questions regarding the new pref, see https://groups.google.com/forum/#!topic/mozilla.dev.platform/th7gTtRSgo0.

[Snuffleupagus]

trying to figure out when we regressed the warning bar

When I'm looking at the code that should trigger the warning, viewer.js#L1741-L1749, I'm not sure how it ever worked :-)
The current code assumes that when the page has been rendered, so has the text layer. This is obviously not true in general, so we might need to add a textlayerrendered event as well (beside the pagerendered one).

[Snuffleupagus]

Do we need to wait for the resolution of https://bugzilla.mozilla.org/show_bug.cgi?id=1118032, or can we land this now? Also, should we use preprocessor tags? E.g.

  if (getIntPref('browser.display.document_color_use', 0) === 2) {
    return false;
  }
//#if !MOZCENTRAL
  if (!getBoolPref('browser.display.use_document_colors', true)) {
    return false;
  }
//#endif
  return true;

[gijsk]

We don't need to wait; that bug will only change the representation of the pref in the preference pages, not the values of the pref

[Snuffleupagus]

Thanks for the patch!