removed rounding of values in composeSMaskLuminosity #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingFabian
force-pushed
the
remove-canvas-rounding-luminosity
branch
from
5914153 to
d5136c1
Compare
maskData comes out of maskCtx.getImageData, so is 0..255 clamped, and the used multiplications will not create fractions needing rounding, neither would addition.
CodingFabian
force-pushed
the
remove-canvas-rounding-luminosity
branch
from
d5136c1 to
b049119
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.22.172.223:8877/5baf5db87fb1c8d/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.21.233.14:8877/9a3fe6ffaf8b5ea/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/5baf5db87fb1c8d/output.txt Total script time: 2.86 mins
Image differences available at: http://107.22.172.223:8877/5baf5db87fb1c8d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9a3fe6ffaf8b5ea/output.txt Total script time: 23.69 mins
|
|
Okay, we can take it :) Thanks! |
yurydelendik
added a commit
that referenced
this pull request
Dec 5, 2014
…inosity removed rounding of values in composeSMaskLuminosity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maskData comes out of maskCtx.getImageData, so is 0..255 clamped, and
the used multiplications will not create fractions needing rounding,
neither would addition.
Not a big deal, but composeSMaskLuminosity pops up in profiles, so at
least its somewhat relevant, even when the operator itself disappears in
noise when trying to profile it with the limited tools we have in js.