Disable PresentationMode for certain problematic configurations #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might work fine. Can you add this variable and the docs to the api.js? |
|
Instead of just detecting by user agent, is it possible to also detect based on whether or not there exists specific functions that are faulty? |
Instead of trying to hack around various browser defects, let's just disable PresentationMode in the affected browsers. This patch: - Disables PresentationMode in IE11+ when the viewer is embedded; fixes 4711.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/4edaff469d2c6ed/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/4edaff469d2c6ed/output.txt Total script time: 0.92 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Mar 13, 2015
Disable PresentationMode for certain problematic configurations
|
Thank you! To summarize, in the end we were able to fix presentation mode for Safari in #5838, so this patch targets only IE instead of IE and Safari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to hack around various browser defects, let's just disable PresentationMode in the affected browsers. This patch: