Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates/refactors PDFPageView class #5552

Merged
merged 10 commits into from
Jan 5, 2015
Merged

Creates/refactors PDFPageView class #5552

merged 10 commits into from
Jan 5, 2015

Conversation

yurydelendik
Copy link
Contributor

Allows just to paint a single PDF page. Also makes TextLayerBuilder much simpler to use.

existentialism
existentialism reviewed Dec 18, 2014
View reviewed changes
web/text_layer_builder.js
this.textDivs = [];
this.findController = options.findController || null;
this.complete = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used anywhere else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks

@yurydelendik yurydelendik mentioned this pull request Dec 18, 2014
Closed
@Snuffleupagus
Copy link
Collaborator

When scrolling really fast through e.g. tracemonkey.pdf with these patches applied locally, I get an error in the console:

TypeError: visibleViews is undefined                    pdf_rendering_queue.js:110:10

It appears that it's connected with cancelling of page rendering, since in these cases visibleViews === 'cancelled' at pdf_viewer.js#L608.

@yurydelendik
Copy link
Contributor Author

When scrolling really fast through e.g. tracemonkey.pdf with these patches applied locally, I get an error in the console

Fixed

@Snuffleupagus
Copy link
Collaborator

Review progress:

  • Renames page_view.js file
  • Simple restructuring PageView into PDFPageView
  • Creates IPDFTextLayerFactory interface
  • Removes PDFPageSource
  • Creates AnnotationsLayerBuilder
  • Removes Stats dependency from PDFPageView
  • Refactors Cache into PDFPageViewBuffer
  • Removes lastScrollSource and isViewerInPresentationMode from TextLayerBuilderOptions
  • Refactors draw method in PDFPageView; makes optional some PDFPageViewOptions options
  • Replaces text selection example

@yurydelendik yurydelendik force-pushed the pdfpageview branch 2 times, most recently from dd3e4bf to 84afd3f Compare December 18, 2014 18:56
This was referenced Dec 18, 2014
Closed
Closed
@yurydelendik yurydelendik added this to the 2014 Q4 milestone Dec 19, 2014
@yurydelendik yurydelendik force-pushed the pdfpageview branch 2 times, most recently from 96557e9 to 0a171f7 Compare December 19, 2014 21:34
@yurydelendik yurydelendik force-pushed the pdfpageview branch 2 times, most recently from e4b3bdc to 9a5da2e Compare December 20, 2014 00:11
@yurydelendik
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4d631026e04c398/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/4d631026e04c398/output.txt

Total script time: 0.77 mins

Published

@Snuffleupagus
Copy link
Collaborator

As far as I'm concerned, this is good to go now!

@brendandahl Do you agree?

@yurydelendik yurydelendik mentioned this pull request Jan 2, 2015
Closed
brendandahl added a commit that referenced this pull request Jan 5, 2015
@brendandahl
Merge pull request #5552 from yurydelendik/pdfpageview
e93cf5c 
Creates/refactors PDFPageView class
@brendandahl brendandahl merged commit e93cf5c into mozilla:master Jan 5, 2015
@nschloe
Copy link
Contributor

nschloe commented Jan 5, 2015

Is there example code for how to use this?

@yurydelendik
Copy link
Contributor Author

@nschloe yes, see the example in the last commit

@yurydelendik
Copy link
Contributor Author

or examples/components/pageviewer.html

@timvandermeij
Copy link
Contributor

Awesome work!

@yurydelendik yurydelendik mentioned this pull request Jan 10, 2015
Merged
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
@brendandahl
Merge pull request mozilla#5552 from yurydelendik/pdfpageview
7f9561c 
Creates/refactors PDFPageView class
@Snuffleupagus Snuffleupagus mentioned this pull request Sep 25, 2015
Merged
@yurydelendik yurydelendik deleted the pdfpageview branch January 28, 2016 21:04
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Snuffleupagus Snuffleupagus

Labels
viewer
Projects
None yet
Milestone
2014 Q4
Development

Successfully merging this pull request may close these issues.
7 participants
@yurydelendik @Snuffleupagus @pdfjsbot @nschloe @timvandermeij @existentialism @brendandahl