-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors getDocument and adds PDFDataRangeTransport. #5554
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f1c739253fa1bcd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f7211fa8fad75c0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f7211fa8fad75c0/output.txt Total script time: 17.11 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f1c739253fa1bcd/output.txt Total script time: 22.43 mins
|
} | ||
|
||
RenderTask.prototype = /** @lends RenderTask.prototype */ { | ||
/** | ||
* Promise for rendering task completion. | ||
* @type {Promise} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: @returns {Promise}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
a19f9f3
to
67e4aa4
Compare
Fixes #5277 |
* @return {Promise} A promise that is resolved after the onFulfilled or | ||
* onRejected callback. | ||
*/ | ||
then: function RenderTask_then(onFulfilled, onRejected) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: copy-and-paste error in the function name RenderTask
-> PDFDocumentLoadingTask
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Change |
Fixed. |
* | ||
* @param {function} passwordCallback is optional. It is used to request a | ||
* @param {function} passwordCallback (obsolete) It is used to request a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we used the word "obsolete" before, but "deprecated" really makes more sense for all of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Refactors getDocument and adds PDFDataRangeTransport.
Refactors getDocument and adds PDFDataRangeTransport.
No description provided.