Remove unused anchor links placed before every page #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In old versions of the viewer, anchor links were used to be able to scroll a page into view. Since we for quite some time have had a `scrollIntoView` function which handles this, the anchor links are no longer necessary and I believe that they can be removed. Doing so will reduce the total number of DOM elements in the viewer. For most documents this patch will probably not make much of a difference performance wise, but for very long (1000+ pages) documents this could help performance especially on lower powered hardware.
|
Trivial, I believe that can be merged. @yurydelendik |
|
Regarding merging this, please see http://logs.glob.uno/?c=mozilla%23pdfjs&s=6+Jan+2015&e=6+Jan+2015#c29091. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/33a6d7cdd763c1d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/33a6d7cdd763c1d/output.txt Total script time: 0.77 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jan 23, 2015
Remove unused anchor links placed before every page
|
Great, thank you! |
speedplane
pushed a commit
to speedplane/pdf.js
that referenced
this pull request
Feb 24, 2015
…chor Remove unused anchor links placed before every page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In old versions of the viewer, anchor links were used to be able to scroll a page into view. Since we for quite some time have had a
scrollIntoViewfunction which handles this, the anchor links are no longer necessary and I believe that they can be removed. Doing so will reduce the total number of DOM elements in the viewer.For most documents this patch will probably not make much of a difference performance wise, but for very long (1000+ pages) documents this could help performance especially on lower powered hardware.