Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCITTFaxStream: fix regression when EncodedByteAlign is true and EndOfLine is false #5597

Merged
merged 1 commit into from
Dec 30, 2014

Conversation

timvandermeij
Copy link
Contributor

Fixes #5592.

I have manually checked the files from #5136 to be sure that they still render the same as before. This PR makes sure that PDFs where EncodedByteAlign is true and EndOfLine is false also enter the EOL check. See http://logs.glob.uno/?c=mozilla%23pdfjs&s=29+Dec+2014&e=29+Dec+2014#c28841 for more information.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/343c0df86ea76f8/output.txt

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1f6d1dfebc34556/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5a52587006d6c05/output.txt

@timvandermeij timvandermeij changed the title CCITTFaxStream: fix regression for PDFs that are not byte-aligned CCITTFaxStream: fix regression when EncodedByteAlign is true and EndOfLine is false Dec 29, 2014
@timvandermeij
Copy link
Contributor Author

Note: After I ran the tests, I have amended the commit message. Nothing has been changed in the commit itself.

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/5a52587006d6c05/output.txt

Total script time: 17.59 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1f6d1dfebc34556/output.txt

Total script time: 23.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@CodingFabian
Copy link
Contributor

change looks trivial. it passes the PDFs the original PR addressed, passes regression tests where the new PDF was added.
should be merged.

@Snuffleupagus
Copy link
Collaborator

Thanks for the patch!

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/07fe09dc49142d3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/02a53d4fef97ea8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/02a53d4fef97ea8/output.txt

Total script time: 17.18 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/07fe09dc49142d3/output.txt

Total script time: 23.05 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Snuffleupagus added a commit that referenced this pull request Dec 30, 2014
CCITTFaxStream: fix regression when EncodedByteAlign is true and EndOfLine is false
@Snuffleupagus Snuffleupagus merged commit 6e66e30 into mozilla:master Dec 30, 2014
@timvandermeij timvandermeij deleted the ccitt-regression branch December 30, 2014 12:50
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
CCITTFaxStream: fix regression when EncodedByteAlign is true and EndOfLine is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF not rendered
4 participants