Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that |get fingerprint| doesn't fail if the ID is not an array (issue 5599) #5602

Merged
merged 1 commit into from
Dec 30, 2014
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

According to the PDF specification the ID should be an array. To prevent errors if the PDF file violates that part of the spec, check that the ID is actually an array.

Fixes #5599.

…(issue 5599)

According to the [PDF specification](http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#page=51) the `ID` should be an array. To prevent errors if the PDF file violates that part of the spec, check that the `ID` is actually an array.

Fixes 5599.
@Snuffleupagus Snuffleupagus changed the title Ensure that |get fingerprint| doesn't fail if the ID is not an array (is... Ensure that |get fingerprint| doesn't fail if the ID is not an array (issue 5599) Dec 30, 2014
@Snuffleupagus
Copy link
Collaborator Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/328a44bbfe8a0b7/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ed8c93aa9edf7f9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://107.21.233.14:8877/794597dcd1b1e2d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/ed8c93aa9edf7f9/output.txt

Total script time: 17.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/794597dcd1b1e2d/output.txt

Total script time: 22.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

Looks really good to me and I also find the code more readable this way!

yurydelendik added a commit that referenced this pull request Dec 30, 2014
Ensure that |get fingerprint| doesn't fail if the ID is not an array (issue 5599)
@yurydelendik yurydelendik merged commit 55098bc into mozilla:master Dec 30, 2014
@yurydelendik
Copy link
Contributor

Really good. Thank you!

@Snuffleupagus Snuffleupagus deleted the issue-5599 branch December 30, 2014 16:27
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
Ensure that |get fingerprint| doesn't fail if the ID is not an array (issue 5599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken pdf: "str is undefined"
4 participants