Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 example and be more flexible what type of data is passed #5624

Merged
merged 1 commit into from
Jan 12, 2015

Conversation

yurydelendik
Copy link
Contributor

Somewhat non-optimal way people whats to pass PDF data. We will not perform base64 decoding, but we will be more flexible on which types are passed to the getDocument({data:..}) ... still thinking about doing conversion in the api.js (vs worker.js)

@yurydelendik yurydelendik force-pushed the base64 branch 3 times, most recently from 2425e40 to 2f6a8ef Compare January 9, 2015 16:00
@yurydelendik
Copy link
Contributor Author

@yurydelendik
Copy link
Contributor Author

"Array-like object" means, e.g. {0: 5, 1: 7, length: 2}. It's acceptable as parameter for Uint8Array (at least for the browsers I test it on)

(e.g. node.js's Buffer or JSON deserialized object)

@yurydelendik yurydelendik force-pushed the base64 branch 3 times, most recently from e27e6c0 to 81649b0 Compare January 12, 2015 20:52
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/fcf0dbebe06ad61/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/54e6c0abac0bb6b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6bc89dd3a130062/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/54e6c0abac0bb6b/output.txt

Total script time: 17.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/6bc89dd3a130062/output.txt

Total script time: 22.98 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Jan 12, 2015
Base64 example and be more flexible what type of data is passed
@timvandermeij timvandermeij merged commit 95fcbc2 into mozilla:master Jan 12, 2015
@timvandermeij
Copy link
Contributor

Nice work!

speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
Base64 example and be more flexible what type of data is passed
@yurydelendik yurydelendik deleted the base64 branch January 28, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants