Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973) #5634

Merged
merged 1 commit into from
Feb 11, 2015
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

This is a tentative patch that adds support for (0, 0) cmap tables. References available here and here.
Since those tables use "standard" Unicode, I hope that my assumption to just use the charCodes as is, is a reasonable one!

Fixes #5501.
Fixes #5574.
Fixes bug 1037973.

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/da09b6e8d84d173/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b2792ec9ff561b0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9f6a12f7645fc3d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9f6a12f7645fc3d/output.txt

Total script time: 17.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b2792ec9ff561b0/output.txt

Total script time: 23.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

Looks really good to me and I can confirm that this fixes the referenced issues. Nice work!

@Snuffleupagus Snuffleupagus changed the title Add support for TrueType (0, 0) cmap tables (issue 5501 and 5574) Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973) Feb 5, 2015
@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/95bbcbd8c0bbbfe/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d80eed2a6919c2c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/95bbcbd8c0bbbfe/output.txt

Total script time: 1.06 mins

  • Lint: Passed
  • Make references: FAILED

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/d80eed2a6919c2c/output.txt

Total script time: 1.26 mins

  • Lint: Passed
  • Make references: FAILED

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8a41b39783f9c5f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8db5090d4eb5450/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/8db5090d4eb5450/output.txt

Total script time: 0.88 mins

  • Lint: Passed
  • Make references: FAILED

@brendandahl
Copy link
Contributor

/botio-linux makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b5813770f1aee58/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/8a41b39783f9c5f/output.txt

Total script time: 17.18 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b5813770f1aee58/output.txt

Total script time: 22.72 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

brendandahl added a commit that referenced this pull request Feb 11, 2015
Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973)
@brendandahl brendandahl merged commit fb82000 into mozilla:master Feb 11, 2015
@brendandahl
Copy link
Contributor

Nice work!

@Snuffleupagus Snuffleupagus deleted the cmap-0,0 branch February 12, 2015 10:12
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully scrambled output PDF fonts misrendered
4 participants