-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973) #5634
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/da09b6e8d84d173/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/da09b6e8d84d173/output.txt Total script time: 1.14 mins Published
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b2792ec9ff561b0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9f6a12f7645fc3d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9f6a12f7645fc3d/output.txt Total script time: 17.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b2792ec9ff561b0/output.txt Total script time: 23.10 mins
|
Looks really good to me and I can confirm that this fixes the referenced issues. Nice work! |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/95bbcbd8c0bbbfe/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d80eed2a6919c2c/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/95bbcbd8c0bbbfe/output.txt Total script time: 1.06 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/d80eed2a6919c2c/output.txt Total script time: 1.26 mins
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8a41b39783f9c5f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8db5090d4eb5450/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/8db5090d4eb5450/output.txt Total script time: 0.88 mins
|
/botio-linux makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b5813770f1aee58/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/8a41b39783f9c5f/output.txt Total script time: 17.18 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b5813770f1aee58/output.txt Total script time: 22.72 mins
|
Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973)
Nice work! |
Add support for TrueType (0, 0) cmap tables (issue 5501, issue 5574, and bug 1037973)
This is a tentative patch that adds support for (0, 0) cmap tables. References available here and here.
Since those tables use "standard" Unicode, I hope that my assumption to just use the charCodes as is, is a reasonable one!
Fixes #5501.
Fixes #5574.
Fixes bug 1037973.