Amend the docs for |disableAutoFetch| to mention that streaming must also be disabled #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c6e8c33a176a57f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c6e8c33a176a57f/output.txt Total script time: 0.80 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jan 14, 2015
…g-docs Amend the docs for |disableAutoFetch| to mention that streaming must also be disabled
|
Trivial. Thanks! |
speedplane
pushed a commit
to speedplane/pdf.js
that referenced
this pull request
Feb 24, 2015
…treaming-docs Amend the docs for |disableAutoFetch| to mention that streaming must also be disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that
disableStream = trueis necessary fordisableAutoFetch = trueto work, is something that I initially overlooked myself (see #5371).It now appears that users of PDF.js are beginning to facing the same issue, see e.g. #3811 (comment) and IRC log.
We should perhaps look into if we need to make any code changes to make the current situation clearer, e.g. #5371 (comment), but in the meantime lets at least add a note about it in the docs.